[tor-bugs] #18931 [Metrics/CollecTor]: coding style polishing

[Tor Bug Tracker & Wiki]

#18931: coding style polishing
-------------------------------+-----------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  task               |         Status:  merge_ready
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------

Comment (by karsten):

 Replying to [comment:2 iwakeh]:
 > Wow, that was quick! And it looks fine!

 Great, thanks for looking!  Merged to master.

 > Maybe, we should remove the !CatchParameterName check?

 I made that check less strict by allowing variable names consisting of
 only one character.  Also merged to master.

 > I'd like to have  a separate ticket for javadoc. Also for a discussion
 > about how much javadoc is necessary.

 Makes sense.  Want to create that ticket and start the discussion?

 > The things left (mostly renaming) can be done when working on other
 things,
 > so I would suggest closing this after adding the javadoc ticket and
 removing
 > the !CatchParameterName check, if you agree.

 Sounds great to me.  Please do!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18931#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online