[tor-bugs] #18920 [Core Tor/Tor]: Make consensus GETINFO return 551 when using microdescs

[Tor Bug Tracker & Wiki]

#18920: Make consensus GETINFO return 551 when using microdescs
------------------------------+--------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  small         |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 The tor control-spec says that 551 should be returned for "dir/status"
 queries where microdescs are in use, and so full descriptors are
 unavailable.
 https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n737

 This doesn't happen for dir/status-vote/current/consensus when tor only
 has a microdesc consensus, instead, tor returns "552 Unrecognized key "dir
 /status-vote/current/consensus".
 https://gitweb.torproject.org/tor.git/tree/src/or/control.c#n2004

 The 552 is misleading and not to spec, instead, we should return 551 with
 a helpful error message.

 Credit to s0rlxmh0 for reporting this issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18920>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online