[tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
---------------------------------------------+-----------------------------
 Reporter:  mcs                              |          Owner:  tbb-team
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Applications/Tor Browser         |      Milestone:
 Severity:  Normal                           |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R  |     Resolution:
Parent ID:                                   |  Actual Points:
 Reviewer:                                   |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by arthuredelstein):

 * keywords:  ff45-esr => ff45-esr, TorBrowserTeam201604R
 * status:  new => needs_review


Comment:

 I previously tried upstreaming our #16488 patch to Firefox, but Chris
 Karlof pointed out to me that the approach is rather Tor Browser-specific:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1217295

 So here's a torbutton patch that accomplishes the same thing:
 https://github.com/arthuredelstein/torbutton/commit/18743
 Hash 242777b8336128995219470275d50b6b6788acb1

 We could then drop the tor-browser.git patch:
 https://github.com/arthuredelstein/tor-browser/commit/18743+1
 Hash c23e50149bc76dfa0529b51f64947f556903c34f

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18743#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online