[tor-bugs] #18741 [Applications/Tor Browser]: OCSP and favicon isolation is only partly working in ESR 45

[Tor Bug Tracker & Wiki]

#18741: OCSP and favicon isolation is only partly working in ESR 45
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  High                                 |         Status:
Component:  Applications/Tor Browser             |  needs_review
 Severity:  Major                                |      Milestone:
 Keywords:  ff45-esr, tbb-6.0a5,                 |        Version:
  TorBrowserTeam201604R                          |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:12 mcs]:
 > Replying to [comment:11 gk]:
 > > [snip]
 > > Sounds like a good approach we could test in the alpha. One nit:
 > >
 > > There is no need for an additional `node->IsElement()` check as you
 are landing in the `if`-block only after the `node->IsElement()` check
 passes.
 >
 > Yes, r=brade and r=mcs if you remove the extra IsElement() check.

 Here's the new branch with this nit fixed. I am currently running a
 3-platform build and will also run mochitests on linux when it's ready. I
 have already run the mochitest on OS X and it all passes.

 https://github.com/arthuredelstein/tor-browser/commits/16326+5
 hash: e8765c0bd920734cb1bcfa5fe00c77f45a7c9a2d

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18741#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online