[tor-bugs] #18546 [Applications/Tor Browser]: Review networking code for Firefox 45

[Tor Bug Tracker & Wiki]

#18546: Review networking code for Firefox 45
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
     Type:  task                                 |  mikeperry
 Priority:  Very High                            |         Status:
Component:  Applications/Tor Browser             |  assigned
 Severity:  Critical                             |      Milestone:
 Keywords:  ff45-esr, MikePerry201604,           |        Version:
  TorBrowserTeam201604                           |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:4 mikeperry]:
 > Here's the quick notes for stuff that really needs another set of eyes:
 >  * We need to verify the proper application of our OCSP and NSS safety
 patches in security/nss. Last time we improperly applied the DNS patch
 while rebasing. That might happen again here, too.

 They look good to me.

 >  * We should make sure that ./netwerk/dns/mdns/libmdns/ is Android only
 and also disabled for OrFox

 This is #18221.

 >  * The "Presentation API" stuff seems new, but possibly not enabled yet.
 It has lots of networking things. We should make sure it is disabled.
 >  * The nsDNSService patches should be verified for the same reason as
 the NSS ones
 >  * There's some resolver stuff in Android that uses SOCK_DGRAM. We
 should make sure this is not active in OrFox
 >  * It looks like
 ./toolkit/modules/secondscreen/SimpleServiceDiscovery.jsm is included now?
 Can we kill it? And what is this second screen stuff?
 >  * dom.udpsocket and dom.moztcpsocket are still off, yes?
 >  * We disabled/patched the debugger and related discovery stuff before,
 right? Is that still off?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18546#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online