[tor-bugs] #16794 [Tor]: All cryptography unit test coverage should be over 95%; all should have test vectors

[Tor Bug Tracker & Wiki]

#16794: All cryptography unit test coverage should be over 95%; all should have
test vectors
---------------------------------+------------------------------------
 Reporter:  nickm                |          Owner:  nickm
     Type:  enhancement          |         Status:  assigned
 Priority:  Medium               |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor                  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:  #16791               |         Points:  medium
 Reviewer:                       |        Sponsor:  SponsorS-can
---------------------------------+------------------------------------

Comment (by nickm):

 by my latest, we're down to one under-covered file, but it's the big one:
 {{{
 cov/crypto.c.gcov 195 935 82.74
 cov/crypto_curve25519.c.gcov 3 85 96.59
 cov/crypto_ed25519.c.gcov 5 148 96.73
 cov/crypto_format.c.gcov 0 92 100.00
 cov/crypto_pwbox.c.gcov 1 63 98.44
 cov/crypto_s2k.c.gcov 1 136 99.27
 cov/aes.c.gcov 0 19 100.00
 }}}

 Also, looking at test_crypto, I see official-looking test vectors for:
    * SHA1
    * SHA256
    * SHA3-{256,512}
    * SHAKE256
    * Curve25519
    * SipHash

 And I see test vectors that we generated with independent code for:
    * AES
    * Base16
    * Base32
    * Base64
    * KDF-TAP
    * HKDF-SHA256
    * Ed25519

 But not for:
    * SHA512
    * RSA
    * DH

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16794#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online