[tor-bugs] #18613 [Tor]: Tor could use a set of BUG_ON, BUG, etc macros to help us use tor_assert less.

[Tor Bug Tracker & Wiki]

#18613: Tor could use a set of BUG_ON, BUG, etc macros to help us use tor_assert
less.
-------------------------------+------------------------------------
 Reporter:  nickm              |          Owner:  nickm
     Type:  enhancement        |         Status:  accepted
 Priority:  High               |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor                |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  TorCoreTeam201604  |  Actual Points:
Parent ID:                     |         Points:  small
 Reviewer:                     |        Sponsor:  SponsorU-can
-------------------------------+------------------------------------

Comment (by nickm):

 The name "tor_assert_nonfatal" seems to be winning the straw-poll I took.
 I'm defining it with the variants:
    * tor_assert_nonfatal()
    * tor_assert_nonfatal_once()
    * tor_assert_nonfatal_unreached()
    * tor_assert_nonfatal_unreached_once()

 I'm also changing the default definition for tor_fragile_assert() to
 tor_assert_nonfatal_unreached_once().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18613#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online