[tor-bugs] #18466 [Tor Browser]: Fix torbutton for ESR45

[Tor Bug Tracker & Wiki]

#18466: Fix torbutton for ESR45
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  gk
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor Browser                          |      Milestone:
 Severity:  Critical                             |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R,     |     Resolution:
  GeorgKoppen201604 tbb-6.0a5                    |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:13 mcs]:
 > Replying to [comment:10 gk]:
 > > Part of the pain here is due to
 https://bugzilla.mozilla.org/show_bug.cgi?id=589199 (see:
 https://blog.mozilla.org/addons/2015/10/14/breaking-changes-let-const-
 firefox-nightly-44/).
 >
 > Yes, these incompatible changes seem to be causing a lot of pain across
 the Firefox extension universe. The patch that you point to in comment:11
 looks fine. I wonder if we missed any other things like this in Tor
 Launcher or Torbutton. How did you find these ones? I assume you noticed
 something was not functioning correctly?

 Yes, I kicked Tor Browser until the issues went away and I had all the
 functionality back we currently have with the ESR38. I can try to test Tor
 Launcher a bit more but am pretty confident that it is fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18466#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online