[tor-bugs] #14334 [Tor]: Bugs when registering guard status in connection_or_connect()

[Tor Bug Tracker & Wiki]

#14334: Bugs when registering guard status in connection_or_connect()
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  asn
     Type:  defect                               |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-guard, 027-triaged-1-in,         |        Version:  Tor:
  PostFreeze027, TorCoreTeam201604               |  0.2.7
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:  small
                                                 |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:14 nickm]:
 > > Hm, why do you expect entry_guard_register_connect_status() to be
 called there?
 >
 > Because in most cases where the connection fails, we blame the guard.
 It isn't right to blame the guard in this case, but we should IMO actually
 say so.

 Sounds good. I pushed a fixup commit that adds a comment. :)

 [I change this ticket to "ready for merge". Hope that's a good way to use
 this feature.]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14334#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online