[tor-bugs] #17862 [Tor]: Stop distributing rebuildable files
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Apr 6 14:38:27 UTC 2016
#17862: Stop distributing rebuildable files
-------------------------+-------------------------------
Reporter: cypherpunks | Owner:
Type: defect | Status: needs_review
Priority: Low | Milestone: Tor: 0.2.???
Component: Tor | Version: Tor: 0.2.4.26
Severity: Minor | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------+-------------------------------
Comment (by cypherpunks):
Replying to [comment:7 teor]:
> Replying to [comment:6 cypherpunks]:
> > Replying to [comment:5 teor]:
> > > Does micro-revision.i end up empty after your test, or does it have
the git version in it?
> > It contains two double quotes (`""`) because the extracted directory
isn't a git directory.
>
> Based on comment 1, we want that file to be distributed with the git
revision in it.
> So this is exactly what we don't want.
Somehow i missed that part of the comment, sorry. I'm still curious about
the reasoning behind the existence of the file in the tarball though.
Isn't the version number enough to track down the commit? Versions are
tagged to a specific commit so the file will always match this commit.
IMHO it doesn't add anything.
People that build Tor from the source code repository trigger the micro-
revision rule so their builds will and should include the git revision and
in those cases it's useful.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17862#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list