[tor-bugs] #15197 [Tor Browser]: Rebase Tor Browser patches to ESR 45

[Tor Bug Tracker & Wiki]

#15197: Rebase Tor Browser patches to ESR 45
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:
     Type:  task                            |  arthuredelstein
 Priority:  Very High                       |         Status:
Component:  Tor Browser                     |  needs_revision
 Severity:  Critical                        |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201604  |        Version:
Parent ID:                                  |     Resolution:
 Reviewer:                                  |  Actual Points:
                                            |         Points:
                                            |        Sponsor:  SponsorU
--------------------------------------------+------------------------------

Comment (by mcs):

 We completed our review of all of the brade/mcs patches. Here are the
 additional things we found:

 The "fixup" patch for #13252 is missing
 (b9a6bef70d96a5aab0cea088d2dc3da4a17354a0 on tor-browser-38.7.1esr-6.0-1).
 Arthur: do you want us to rebase that patch or are you planning to do it?

 For #6786 (upstreamed), we need to ensure that
 ui.use_standins_for_native_colors = true.

 For #12827 (f1a5dfae111d9ab281e766a67ae00559cc13578a), some additional
 changes are needed.  Kathy and I can provide a fixup patch or a revised
 patch; which one do you prefer?

 For #6253 (1914acdc24d3fdcdc3e94d24b4225f6804004f75), additional work is
 needed (a crash is occurring inside canvas.getImageData). Kathy and I have
 not debugged this yet.  The patch looked like it was correctly rebased, so
 something must have changed inside Firefox to cause the crash.

 For #16488 (3b20b1e58f08883f6dc2aba44091c49780a11982), additional work is
 needed. The "Sync in to Sync" text is hidden but the icon is not.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15197#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online