[tor-bugs] #15197 [Tor Browser]: Rebase Tor Browser patches to ESR 45
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Apr 4 22:26:28 UTC 2016
#15197: Rebase Tor Browser patches to ESR 45
--------------------------------------------+------------------------------
Reporter: gk | Owner:
Type: task | arthuredelstein
Priority: Very High | Status:
Component: Tor Browser | needs_revision
Severity: Critical | Milestone:
Keywords: ff45-esr, TorBrowserTeam201604 | Version:
Parent ID: | Resolution:
Reviewer: | Actual Points:
| Points:
| Sponsor: SponsorU
--------------------------------------------+------------------------------
Comment (by bugzilla):
Replying to [comment:19 gk]:
> b98f45490b533834cf19eddf474eef8658ba8921 -- okay (do we want to have the
squash! line in the commit message?)
Where is the Development Guide we can find out from? :)
By the way, have you ensured that your testsuite doesn't use {{{Ci}}},
because:
> Joel, one thing about this patch is that it's going to bork the dozen-
or-so crashtests that use |Components|. Now, those crashtests are green
right now, because currently they'll just throw when they access the
undefined property and the test will finish, which is considered PASS for
crashtests. But they're not testing what they're supposed to.
Is this good to merge everything about configs into one commit?
> 2afa5f4a36b8f5af4b7b6ac82ce1d17d20002c40 -- merge with TB3 commit
It has it's own ticket #16285, doesn't interfere with others, so can be
easily applied / reverted / anything else.
> 9d65a5039cd4c36149680a13285672897b07235d --
It was completely rewritten in #16429: https://github.com/arthuredelstein
/tor-browser/commit/f538052047ad61cf74f926381bc7c41b60fa2a3d
> 810cfbfe2bc3531478b6c266e66eee28aaa79392 --
Seems to be rewritten too, because fixed on master.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15197#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list