[tor-bugs] #17173 [Tor]: Bug: tor_addr_is_internal() called from src/common/address.c:1646 with a non-IP address of type 49 (on Tor 0.2.7.3-rc 9a4cac74fd2f4bb3)

Mon Sep 28 22:40:49 UTC 2015

#17173: Bug: tor_addr_is_internal() called from src/common/address.c:1646 with a
non-IP address of type 49 (on Tor 0.2.7.3-rc 9a4cac74fd2f4bb3)
------------------------+--------------------------------
     Reporter:  fk      |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:  Tor: 0.2.7.3-rc
   Resolution:          |   Keywords:  regression
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------

Comment (by teor):

 fk:
 Also, the patch lines `if (addrs == NULL) return -1;` aren't needed, as
 the existing code does that anyway for empty lists.

 Sebastian:
 We can update the existing unit tests to test for total failure to find
 any addresses.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17173#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online