[tor-bugs] #16906 [Tor Browser]: Code for 38.3.0 ESR is failing to compile with mingw-w64

[Tor Bug Tracker & Wiki]

#16906: Code for 38.3.0 ESR is failing to compile with mingw-w64
---------------------------+-----------------------------------------------
     Reporter:  gk         |      Owner:  tbb-team
         Type:  defect     |     Status:  needs_review
     Priority:  blocker    |  Milestone:
    Component:  Tor        |    Version:
  Browser                  |   Keywords:  tbb-gitian, TorBrowserTeam201509R
   Resolution:             |  Parent ID:
Actual Points:             |
       Points:             |
---------------------------+-----------------------------------------------

Comment (by gk):

 This looks good to me. I have two questions, though:

 1) Why do we need the second `ifdef` given that the third `ifdef` prevents
 `sUsingService` from ever getting `true`?

 2) Looking a bit deeper I wonder why we even need the third `ifdef` given
 that `MOZ_USING_SERVICE` gets only set in workmonitor.cpp which in turn
 only gets compiled in if we don't do --disable-maintenance-service.
 Hardening against environment manipulation by some rogue third party
 program?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16906#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online