[tor-bugs] #17097 [Tor Browser]: Print dialog sometimes causes OS X Tor Browser to crash

Thu Sep 17 19:50:33 UTC 2015

#17097: Print dialog sometimes causes OS X Tor Browser to crash
-----------------------------+---------------------------------------------
     Reporter:               |      Owner:  tbb-team
  arthuredelstein            |     Status:  new
         Type:  defect       |  Milestone:
     Priority:  normal       |    Version:
    Component:  Tor Browser  |   Keywords:  tbb-crash, TorBrowserTeam201509
   Resolution:               |  Parent ID:
Actual Points:               |
       Points:               |
-----------------------------+---------------------------------------------

Comment (by arthuredelstein):

 The stack trace indicates that `top` on `ThirdPartyUtil.cpp:651` was null.
 So we need to do a null check there. It also looks safer if we check to
 make sure that `topDoc` is non-null as well.

 Here's a patch for review:
 https://github.com/arthuredelstein/tor-browser/commit/17097

 Once I apply this patch, I no longer get crashes as described.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17097#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online