[tor-bugs] #16962 [Globe]: Switch from displaying "family" field to new "alleged_family" and "effective_family" fields
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Sep 11 00:04:21 UTC 2015
#16962: Switch from displaying "family" field to new "alleged_family" and
"effective_family" fields
-------------------------+----------------------------
Reporter: karsten | Owner: isis
Type: defect | Status: needs_revision
Priority: normal | Milestone:
Component: Globe | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-------------------------+----------------------------
Changes (by isis):
* status: needs_review => needs_revision
Comment:
Replying to [comment:2 clv]:
> Please review branch
[https://github.com/leivaburto/globe/tree/task-16962 task-1696] on my
personal repo. I made a fix for fetching both new fields and formatting
the output with both fields under the same "Family" section but
alleged_family entries are presented with a special CSS class to notice
the difference (screenshot
[https://github.com/leivaburto/globe/commit/67a74642e6ab1838ee4e2a00a5b4c262e1465a5f
available here] - at the end of page).
>
> I wasn't sure if its OK to drop the family field yet (on
!default.js:61).
Hey, clv! Thanks for the patch! I've reviewed it, and it looks great to
me. Would you be able to add another commit to remove the old "family"
field? (I think it's probably okay to remove it.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16962#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list