[tor-bugs] #17020 [Tor]: Add test for Config options_act function

[Tor Bug Tracker & Wiki]

#17020: Add test for Config options_act function
-----------------------------+--------------------------------
     Reporter:  tcz001       |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  testing
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by teor):

 Thank you for this branch. We are trying to increase our test coverage at
 the moment.

 Please find my comments from a read-through of the code below:

 '''Code'''
 * I think we want all our unit tests to succeed in tor2web mode. (I might
 br wrong, do we run unit tests in tor2web mode?) Can you make running
 test_config_options_act_Tor2webMode_err conditional on `#ifndef
 ENABLE_TOR2WEB_MODE`?
 * Should the Tor2webRendezvousPoints part of
 test_config_options_act_circuit_change_by_Nodes_update be conditional on
 `#ifdef ENABLE_TOR2WEB_MODE`? Or does it work regardless?

 '''Coverage / lcov'''
 * I'm not sure if we've using the LCOV_EXCL_ directives elsewhere in the
 tor codebase. We have tended to avoid tool-secific directives unless there
 are compelling reasons.

 '''Splitting into commits'''
 * In future, it will be easier for us to review large branches if they are
 split into different commits. For example, this branch could have been
 spit into:
  * MOCK_* and other declaration changes
  * STATIC/static changes
  * LCOV_EXCL_* changes
  * Whitespace-only or comment-only changes
  * Tor code changes (such as geoip.c lines 1210-1213 - are there any
 others?)
  * Test code changes

 '''Nitpicks'''
 * There are some unnecessary whitespace changes in this branch, such as
 config.c lines 1829-1834, and some of the changes in connection_or.h.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17020#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online