[tor-bugs] #16980 [Tor]: Implicit time range assumption breaks Tor in Shadow

[Tor Bug Tracker & Wiki]

#16980: Implicit time range assumption breaks Tor in Shadow
----------------------------+--------------------------------
     Reporter:  robgjansen  |      Owner:
         Type:  defect      |     Status:  new
     Priority:  normal      |  Milestone:
    Component:  Tor         |    Version:  Tor: 0.2.7.2-alpha
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+--------------------------------

Comment (by robgjansen):

 Interesting, I've been running Tor this way since Shadow was created, and
 I haven't had too many issues.

 Of course I can handle this from within Shadow by adding a constant offset
 to the emulated time. Regardless, IMO, I think it is dangerous to accept
 negative inputs to a function that assumes they are not, and without
 assertions. Maybe there is a use case here? Otherwise, why not remove the
 function entirely and force calling `crypto_rand_uint64` directly.

 Anyway, feel free to ignore me and close this ticket, and I'll make the
 changes to Shadow to prevent the problem from happening.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16980#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online