[tor-bugs] #16937 [Tor Browser]: The browser.startup.homepage pref has been translated in the Korean bundle

[Tor Bug Tracker & Wiki]

#16937: The browser.startup.homepage pref has been translated in the Korean bundle
-----------------------------+-----------------------------------
     Reporter:  boklm        |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201509R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------
Changes (by mcs):

 * cc: brade, mcs (added)
 * status:  new => needs_review
 * keywords:  TorBrowserTeam201509 => TorBrowserTeam201509R


Comment:

 Kathy and I created a patch to fix the browser.properties files (fix ko
 strings, use '-' instead of '_' in the spellchecker.dictionary values,
 remove unused search engine strings from all translations).  The patch is
 here:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug16937-01&id=0725f976b560b77b0ff00fea7c6ea29f6afdd184

 We would also like to do something to prevent this problem in the future,
 but do not want to over-engineer things. We could:
 1. Do nothing.
 2. Remove the browser.startup.homepage string from browser.properties. If
 we do this, we would need to figure out how to override the
 browser.startup.homepage pref. in a different way. Or we would need to
 post-process the browser.properties files during the Torbutton build
 process to add the browser.startup.homepage property back in. Note that we
 would still have a potential problem with the spellchecker.dictionary
 string which was also translated into Korean.
 3. Modify trans_tools/import-translations.sh to complain loudly if the
 certain strings look wrong when we pull them in from Transifex.
 Opinions?  Kathy and I do not think approach 2 is worth the effort.
 Approach 3 would be ugly but would be helpful, assuming that the person
 who updates the translations notices that import-translations.sh failed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16937#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online