[tor-bugs] #16924 [Tor]: Properly free channel during channel_free_list

[Tor Bug Tracker & Wiki]

#16924: Properly free channel during channel_free_list
---------------------------+--------------------------------
     Reporter:  Sebastian  |      Owner:
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor        |    Version:
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+--------------------------------

Comment (by Sebastian):

 Hrm. We're basically relying on an (undocumented, I think?) implementation
 detail of smartlists. The way I noticed this was that I explicitly zeroed
 the unused parts of the smartlist whenever I removed an entry, which meant
 the old code broke. Afaict that's not illegal according to smartlist's
 contract but it breaks this code here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16924#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online