[tor-bugs] #16620 [Tor Browser]: Transform window.name handling into Firefox patch

[Tor Bug Tracker & Wiki]

#16620: Transform window.name handling into Firefox patch
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  mcs
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Tor Browser                          |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-torbutton-conversion,            |     Resolution:
  TorBrowserTeam201510R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:  SponsorU                             |
-------------------------------------------------+-------------------------

Comment (by mcs):

 Here is a revised patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug16620-03&id=cd8e63be6a6be9377fd81ab8fbfd2ee2230cfc65

 We relocated the code that clears window.name so it runs after the
 previous page has received its unload event. We also added a mochitest
 that tries to use an unload event listener to reinstate the window.name
 value (similar to what http://www.thomasfrank.se/sessvarsTestPage1.html
 does). We did not see a problem even when pages were loaded from the
 cache.

 Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16620#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online