[tor-bugs] #17700 [Tor]: Check full SHA digests in unit tests
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Nov 26 15:28:01 UTC 2015
#17700: Check full SHA digests in unit tests
------------------------+--------------------------------
Reporter: teor | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Normal | Keywords: TorCoreTeam201512
Actual Points: | Parent ID:
Points: | Sponsor:
------------------------+--------------------------------
The current test_crypto_sha unit test only checks the first 20 bytes of
each digest. (The buffer sizes are somewhat out of whack, as we discovered
in #17699.)
While it won't change the outcome of the tests, we really should check the
entire length of each hash.
See my branch sha-unit-tests on https://github.com/teor2345/tor.git
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17700>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list