[tor-bugs] #16940 [Tor Browser]: Implement loading (only) local change notes after a Tor Browser update

[Tor Bug Tracker & Wiki]

#16940: Implement loading (only) local change notes after a Tor Browser update
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  enhancement                     |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Tor Browser                     |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-5.5, TorBrowserTeam201511R  |  Actual Points:
Parent ID:                                  |         Points:
  Sponsor:                                  |
--------------------------------------------+------------------------------

Comment (by gk):

 Replying to [comment:9 mcs]:
 > Replying to [comment:8 gk]:
 > > I've tested the patches on Linux and local change notes are working +
 the code looks good. Nice job! Just two things occurred to me while
 testing/reading the code:
 > >
 > > 1) Should we prepend the value for `startup.homepage_override_url`
 with `about:tbupdate?` as well?
 >
 > about:tbupdate? will be prepended to the overridePage whenever the
 browser is starting immediately after applying an update
 (app.update.postupdate). After the call to getPostUpdateOverridePage(),
 the overridePage value might be the startup.homepage_override_url, the
 value from the update manifest (XML from the server), or an empty string.
 So about:tbupdate? will be added to startup.homepage_override_url. Or are
 we missing something?

 I tested the update changes by applying a MAR-file by hand and then the
 currently specified URL got loaded without `about:tbupdate?` prepended. I
 guess there are people with a bunch of tinfoil-hats out there doing this
 kind of thing regularly, so I was wondering.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16940#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online