[tor-bugs] #17027 [Tor]: policies_parse_exit_policy_internal should block all IPv4 and IPv6 local addresses

[Tor Bug Tracker & Wiki]

#17027: policies_parse_exit_policy_internal should block all IPv4 and IPv6 local
addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.6.x-final
 Keywords:  TorCoreTeam201511, security,         |        Version:  Tor:
  027-backport                                   |  unspecified
Parent ID:                                       |     Resolution:
  Sponsor:                                       |  Actual Points:
                                                 |         Points:
-------------------------------------------------+-------------------------

Comment (by teor):

 This branch needed a fixup from #17183, so I cherry-picked it onto the end
 of bug17027-reject-private-027-v6.

 policies_parse_exit_policy_reject_private Unit Tests

 The unit tests for policies_parse_exit_policy_reject_private assumed too
 much about the interface addresses on the local system. This meant that
 tests failed on some machines.

 I modified the unit tests to assume less, and used a mocked version of
 get_interface_address6_list to provide a range of addresses for testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17027#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online