[tor-bugs] #17183 [Tor]: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate rules

[Tor Bug Tracker & Wiki]

#17183: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate
rules
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  reopened
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  stem, 028-triaged,                   |        Version:  Tor:
  TorCoreTeam201512                              |  unspecified
Parent ID:                                       |     Resolution:
  Sponsor:                                       |  Actual Points:
                                                 |         Points:  small
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 This branch needed two fixes. I have added fixups to getinfo-private-
 exitpolicy-v4 for these issues, which also affect #17027.

 policies_parse_exit_policy_reject_private Unit Tests

 The unit tests for policies_parse_exit_policy_reject_private assumed too
 much about the interface addresses on the local system. This meant that
 tests failed on some machines.

 I modified the unit tests to assume less, and used a mocked version of
 get_interface_address6_list to provide a range of addresses for testing.

 getinfo exit-policy/reject-private/relay Implementation & Unit Tests

 The implementation was ignoring ExitPolicyRejectPrivate and had a memory
 leak. The unit tests didn't set ExitPolicyRejectPrivate, and were missing
 a static on a mock function declaration.

 I fixed these issues.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17183#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online