[tor-bugs] #17618 [Torsocks]: Segfault in tsocks_accept4() if called through syscall()

[Tor Bug Tracker & Wiki]

#17618: Segfault in tsocks_accept4() if called through syscall()
------------------------------+---------------------
     Reporter:  crystalmaker  |      Owner:  dgoulet
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Torsocks      |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |    Sponsor:
------------------------------+---------------------
 Hello,

 There is a segfault in tsocks_accept4() when it is called through
 syscall() and accept4() isn't called first.

 It's because tsocks_libc_accept4 is only initialized through accept4() and
 not syscall().

 From what I can tell this is not only a problem with tsocks_accept4() but
 many other calls made through syscall().

 My suggested fix is to replace the native tsocks calls in syscall.c with
 their libc equivalents. E.g. instead of calling tsocks_accept4(), calling
 accept4().

 Whatever the best fix, I can provide a patch for it given the right
 direction.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17618>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online