[tor-bugs] #17568 [Tor Browser]: Clean up tor-control-port.js in Torbutton

[Tor Bug Tracker & Wiki]

#17568: Clean up tor-control-port.js in Torbutton
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  task                                 |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton,                       |        Version:
  TorBrowserTeam201511R                          |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:8 arthuredelstein]:
 > Here is the new version:
 > https://github.com/arthuredelstein/torbutton/commit/17568+1

 Alright, we are getting closer!

 "// Tor expects any commands to be terminated by CRLF." -> "// Controllers
 should send any commands terminated by CRLF." maybe? (this would reflect
 the spec better where it is a "SHOULD")

 We have `250[-\ ]` and `250[- ]`. I guess we should decide whether we need
 to escape the white space or not... ;)

 It seems we only need info parsers for `ns/id/`, `ip-to-country/`,
 `circuit-status` and `bridge` at the moment. What should we do with the
 other ones, especially if they need a parsing function which is not used
 somewhere else anyway (like the `config-text` case)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17568#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online