[tor-bugs] #17589 [Tor]: Decouple connection_dir_request_failed() from directory_initiate_command_rend()

[Tor Bug Tracker & Wiki]

#17589: Decouple connection_dir_request_failed() from
directory_initiate_command_rend()
------------------------+------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Low     |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:
     Severity:  Minor   |   Keywords:  blob SponsorS refactor
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+------------------------------------
 Instead of calling connection_dir_request_failed() directly,
 directory_initiate_command_rend() should mark the failed connection and
 have it cleaned up later. This would prevent recursive invocation of
 directory_initiate_command_rend(), and remove 12 functions from the Blob.

 I'd do this right now, but I want to test that the code actually does the
 right thing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17589>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online