[tor-bugs] #9659 [Tor Browser]: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP requests if no SOCKS response yet

[Tor Bug Tracker & Wiki]

#9659: Optimistic Data SOCKS variant (patch for #3875) leads to loop on HTTP
requests if no SOCKS response yet
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-usability, tbb-crash-hang, tbb-  |        Version:
  firefox-patch, GeorgKoppen201511R,             |     Resolution:
  TorBrowserTeam201511R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:31 cypherpunks]:
 > It still need to handle case of partial socks answer to be generally
 complete, else code re-starts writing.
 > ...

 Thanks. Kathy and I think it is enough to skip resetting mPollFlags in
 that case. Here is a revised patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug9659-02&id=7ee43c7281e03636b2bab5384ce77073fd6a0aab

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9659#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online