[tor-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time

[Tor Bug Tracker & Wiki]

#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:  new
Component:  Tor Browser                          |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-torbutton tbb-circuit-display    |     Resolution:
  TorBrowserTeam201511                           |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-torbutton tbb-circuit-display => tbb-torbutton tbb-
     circuit-display TorBrowserTeam201511
 * cc: arthuredelstein (added)


Comment:

 I think I've tracked that one down. The bug is in `info.stringToValue()`
 in `tor-control-port.js`. More exactly
 {{{
 string.match(/250[ -].+?=(.*?)$/mi)
 }}}
 is wrong. There are (or could be) exit relays out there whose nickname
 ends with "250", e.g.
 https://atlas.torproject.org/#details/B486925DC901969CCE2B371E93740CF98C30539D.
 When this is happening and someone is picking this relay as an exit relay
 the above mentioned code kicks in (although it is not supposed to do that)
 and something like
 {{{
 NEED_CAPACITY PURPOSE=GENERAL TIME_CREATED=2015-11-04T11:33:11.034987
 SOCKS_USERNAME="torproject.org" SOCKS_PASSWORD="0"
 }}}
 gets passed to `utils.listMapData()` (via `info.circuitStatusParser()`)
 resulting in `circID` being `NEED_CAPACITY`. This in turn lets
 `getCircuitStatusByID()` return `null` leading to the missing circuit
 display.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online