[tor-bugs] #4862 [Tor]: Consider disabling dynamic intro point formula (numerology)

[Tor Bug Tracker & Wiki]

#4862: Consider disabling dynamic intro point formula (numerology)
-------------------------+-------------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  needs-proposal, tor-hs,
   Resolution:           |  027-triaged-1-in, SponsorR
Actual Points:           |  Parent ID:
       Points:           |
  medium/large           |
-------------------------+-------------------------------------------------

Comment (by arma):

 Replying to [comment:29 asn]:
 > BTW, what is this change supposed to be doing?
 >
 > {{{
 >      if (!intro_point_set_changed &&
 > -        (n_intro_points_unexpired >= service->n_intro_points_wanted)) {
 > +        (n_intro_points_unexpired == service->n_intro_points_wanted)) {
 >        continue;
 >      }
 > }}}
 >
 > If you know what that block of code does, can you please document it?
 Thanks!

 I haven't looked much at the overall patch, but I think George is right to
 ask about this part. The original code said "if you are going to have
 enough intro points still, you're done." The new code with this change
 seems to go through a weird "if you have more than enough, then proceed
 with the function, and then the for() loop is a no-op, and then we hit
 {{{
     /* If there's no need to launch new circuits, stop here. */
     if (!intro_point_set_changed)
       continue;
 }}}
 "

 So I think the change above just adds a tiny bit of inefficiency and
 confusion, rather than actually changing behavior. But it still looks like
 simplifying and unconfusing would be wise.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4862#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online