[tor-bugs] #12716 [meek]: Make meek-client-torbrowser take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrowser take the firefox command as a parameter
------------------------+----------------------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  needs_revision
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------

Comment (by dcf):

 Replying to [comment:25 infinity0]:
 > Or simpler: if the argument to `--helper` is a `.args` file (or
 whatever), then instead of passing this as a filename to exec.Command,
 read the file and parse it as a line-separated list of arguments to pass
 to exec.Command.

 Actually I like this idea. Only I would not want to then support ''both''
 a script argument or an args argument--I would want there to be only one
 way. Only then we run into the same problem with mac needing an absolute
 profile path... hmm.

 As to the idea with baking in the paths at compile time: we are already
 doing something similar in meek-client-torbrowser. E.g. linux.go has at
 the top
 {{{
 // +build linux
 }}}
 which causes it to be built only on linux (http://golang.org/pkg/go/build
 /#hdr-Build_Constraints). Seeing as firefoxPath and firefoxProfilePath are
 the only things we need to conditionally define, we could just remove
 mac.go, linux.go, and windows.go, and force whoever's building to add
 their own x.go with their own custom paths.

 On another hand, we could just move the entirety of meek-client-torbrowser
 into the tor-browser tree, and establish the convention that other system-
 specific interfaces between meek-client and a browser will also be
 maintained outside the meek tree.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online