[tor-bugs] #15881 [Tor]: Missing descriptor ID in some HS_DESC control event

[Tor Bug Tracker & Wiki]

#15881: Missing descriptor ID in some HS_DESC control event
-------------------------+----------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  SponsorR, controller
Actual Points:           |  Parent ID:
       Points:  small    |
-------------------------+----------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:5 nickm]:
 >  * Can this have tests?

 I think so yes, we have already HS control test, I'll see what I can do.

 >  * In get_desc_id_from_query(), is it possible that the set of
 directories we knew about when we launched the query will not match the
 set that we know about when we call get_desc_id_from_query()?  This could
 happen if we get a new networkstatus in between.

 Hrm... indeed, new consensus, churn occurs and thus we have an erroneous
 HSDir list. Fix to that seems to keep our responsible HSDir in rend_data
 but that's a bit more complicated because that means one different
 rend_data per HSDir connection. So would keeping the full list of HSDir
 fingerprint a reasonable idea?

 >  * Does get_desc_id_from_query() return a (binary) digest or a hex
 string or a base32 string or what?  It should be documented.

 Ack!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15881#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online