[tor-bugs] #15915 [Torbutton]: Circuit display is shown when display_circuit is disabled since Tor Browser start

[Tor Bug Tracker & Wiki]

#15915: Circuit display is shown when display_circuit is disabled since Tor Browser
start
--------------------------+---------------------
 Reporter:  anonym        |          Owner:
     Type:  defect        |         Status:  new
 Priority:  normal        |      Milestone:
Component:  Torbutton     |        Version:
 Keywords:  AffectsTails  |  Actual Points:
Parent ID:                |         Points:
--------------------------+---------------------
 If `extensions.torbutton.display_circuit = false` when starting Tor
 Browser 4.5 with Torbutton 1.9.2.2, then the circuit display will be
 enabled, showing an example circuit (A, B, C) which is confusing and (I
 believe) unintended.

 That pref is bound to the `start()` and `stop()` functions defined in
 `setupDisplay()` (in `src/chrome/content/tor-circuit-display.js`). When
 the pref is `false` we'll call `stop()`, which will call
 `syncDisplayWithSelectedTab(false)` (which disables the display) but it is
 only called *if* `myController` is set. However, `myController` is *not*
 set if this pref was `false` since Tor Browser start so we should move
 `syncDisplayWithSelectedTab(false)` outside of that if statement.

 Here's a patch. Since we in Tails has disabled the circuit view for now,
 we'd greatly appreciate if this could be fixed in the expected Tor Browser
 release (4.5.1?) on 2015-05-12, so this will be fixed in Tails 1.4
 released on the same day.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15915>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online