[tor-bugs] #15872 [Tor Browser]: the meek doesn't start with the torbrowser 4.5

[Tor Bug Tracker & Wiki]

#15872: the meek doesn't start with the torbrowser 4.5
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  zazone2002             |     Status:  new
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-usability, tbb-4.5-regression,
  Browser                |  meek
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by dcf):

 * keywords:  tbb-usability, tbb-4.5-regression => tbb-usability,
     tbb-4.5-regression, meek


Comment:

 It look like this is because of #15606 (itself a result of #15435), which
 made the programs work with the new TOR_PT_EXIT_ON_STDIN_CLOSE convention.
 The bug is `stdin.Close()` here:
   https://gitweb.torproject.org/pluggable-
 transports/meek.git/diff/?id=0.17&id2=0.16
 That call doesn't make any sense, because the purpose of the program is to
 keep the subprogram's stdin open. I tested without it, and meek bootstraps
 on Windows 7. I'll make a new release without it.

 Of course I tested that change on Windows. But I tested on Windows 8, not
 Windows 7. Now I wonder why it works on Windows 8! Is Tor Browser 4.5
 built with the patch from #15435?

 The clue to what was going wrong was the meek-client-torbrowser log:
 {{{
 2015/04/30 20:02:12 meek-client started with pid 3128
 2015/04/30 20:02:12 synthesizing SIGTERM because of stdin close
 2015/04/30 20:02:12 sig terminated
 2015/04/30 20:02:12 sending signal terminated to PID 3128
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15872#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online