[tor-bugs] #15435 [Tor]: Tor should not close stdin on child processes.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Mar 28 03:24:15 UTC 2015
#15435: Tor should not close stdin on child processes.
---------------------------+-----------------------------------------------
Reporter: yawning | Owner:
Type: | Status: needs_review
enhancement | Milestone: Tor: 0.2.7.x-final
Priority: normal | Version: Tor: unspecified
Component: Tor | Keywords: tor-pt, needs-spec-patch pt-wants
Resolution: | Parent ID:
Actual Points: |
Points: |
---------------------------+-----------------------------------------------
Comment (by yawning):
I went and cleaned up/refactored how I do termination in obfs4proxy and
updated my feature branch appropriately.
This is what the termination detection will look like with this feature
added:
https://github.com/Yawning/obfs4/blob/feature15435/obfs4proxy/termmon.go
And this is the calling code:
https://github.com/Yawning/obfs4/blob/feature15435/obfs4proxy/obfs4proxy.go#L437
It's a lot like how `meek-client-torbrowser` does this now, though I have
extra code to detect abnormal tor termination even without this feature.
I guess I can even make `termMonitor.wait()` just return a bool indicating
immediate shutdown or not, but I'm done messing with this for today I
think.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15435#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list