[tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Mar 26 21:05:41 UTC 2015
#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
Reporter: | Owner: arthuredelstein
arthuredelstein | Status: needs_revision
Type: defect | Milestone:
Priority: normal | Version:
Component: Tor | Keywords: tbb-fingerprinting-resolution, tbb-
Browser | torbutton, tbb-4.5-alpha,
Resolution: | TorBrowserTeam201503R, GeorgKoppen201503R
Actual Points: | Parent ID:
Points: |
-------------------------+-------------------------------------------------
Comment (by arthuredelstein):
Replying to [comment:40 gk]:
> 1) If you enter fullscreen mode and reload the page the window height is
not rounded anymore (I get this on Linux OSX and Windows; basically the
height is always off by one)
> 5) If I make the menu bar visible with DPI 125% on Windows, the height
gets off by 1.
I only seem to see this off-by-one effect when zoom is other than 1x. Do
you see this with 1x zoom?
> 6) I did not test the zoom behavior extensively. But just shrinking the
window with every zoom step (regardless whether the text gets smaller or
larger) seems strange to me. If you zoom a couple of times there is almost
no window left. I think we should think a bit harder about that case,
preferably in a different ticket.
New ticket: #15474
> Wrt the #7255 patch: I think you can just revert it and implement a hint
for the user that explains what happened after the resize (as we discussed
in #7255). Having the fix for #7255 with the patch for this ticket makes
not much sense.
>
> Needs_revision is mainly for the latter. I think we could ship the patch
in the next alpha (maybe modulo the zoom part) with the user notification
changes. I am interested in getting feedback from other setups.
I'm working on adding a user notification and disabling the zoom.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list