[tor-bugs] #14065 [BridgeDB]: No vanilla IPv6 bridges found
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Mar 23 03:28:09 UTC 2015
#14065: No vanilla IPv6 bridges found
-------------------------+-------------------------------------------------
Reporter: qwerty1 | Owner: isis
Type: defect | Status: closed
Priority: major | Milestone:
Component: | Version:
BridgeDB | Keywords: bridgedb-https, bridgedb-dist,
Resolution: fixed | isis2015Q1, bridgedb-0.3.1
Actual Points: | Parent ID:
Points: |
-------------------------+-------------------------------------------------
Changes (by isis):
* priority: normal => major
* cc: isis (added)
* status: new => closed
* resolution: => fixed
* keywords: => bridgedb-https, bridgedb-dist, isis2015Q1, bridgedb-0.3.1
Comment:
There is
[https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=fix/14065
-vanilla-ipv6&id=c1a3d4692270b592a3a2efb7d5a14af357f6f91c a regression
test] for this, as well as
[https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=fix/14065
-vanilla-ipv6&id=8507fa30378e85e90b71b54de2bcb2f9537936f4 a fix] for the
bug, in my `fix/14065-vanilla-ipv6`
[https://gitweb.torproject.org/user/isis/bridgedb.git/log/?h=fix/14065
-vanilla-ipv6 branch].
The problem was that, when a client requests IPv6, they are assigned
`addressClass = ipaddr.IPv6Address` (otherwise, `addressClass =
ipaddr.IPv4Address`). Later, in
`bridgedb.bridgerequest.BridgeAddressBase.__init__()`, that `addressClass`
was checked to determine if it is an instance of either
`ipaddr.IPv4Address` or `ipaddr.IPv6Address` — the problem here being that
it isn't ever an instance, it ''is'' the class, so the check to see if it
was an instance would fail, and it would get reassigned to the default
`addressClass = ipaddr.IPv4Address`, causing IPv6 request to return IPv4
addresses.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14065#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list