[tor-bugs] #15211 [Tor]: Audit all asserts to ensure they don't have side effects

[Tor Bug Tracker & Wiki]

#15211: Audit all asserts to ensure they don't have side effects
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  minor        |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by Sebastian):

 No I think I got all of them. I looked at:
  - every multi-line assert individually
  - every assert where we have an opening brace before ;
  - every assert where we have assignment, including +=, *=, ++, etc (we
 have zero of these)

 Thanks for merging and the const fix. Clearly I should work on my const-
 correctness

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15211#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online