[tor-bugs] #15215 [Tor]: Use destination address type in SOCKS5 reply rather than AP address

[Tor Bug Tracker & Wiki]

#15215: Use destination address type in SOCKS5 reply rather than AP address
------------------------+--------------------------------
     Reporter:  sysrqb  |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * milestone:  Tor: 0.2.7.x-final => Tor: 0.2.6.x-final


Comment:

 We can consider it for 0.2.6, I guess, but I still don't think I
 understand.  Let me try to unpack my thoughts.

 The old behavior (in 0.2.5 and earlier), was that if you connected to
 SocksPort over IPv4 you got "0.0.0.0" as your address, and otherwise you
 were connecting over IPv6 so you got "[::]" as your address.

 In 0.2.6, with the addition of AF_UNIX sockports, the behavior is that if
 you connected to SocksPort over IPv4 you got "0.0.0.0" as your address,
 and otherwise you are connecting over IPv6 OR AF_UNIX so you get "[::]" as
 your address.

 The proposed change is that if the target address is an IPv4 address, we
 say "0.0.0.0" regardless of how you connected to Tor, and otherwise we say
 "[::]" regardless of how you connected to Tor.  Is that right?

 (Are we looking at the address the user asked for or the address in the
 CONNECTED cell?  I think maybe you told me the latter, but I can't see
 where that would be getting set.  Also, what happens with hidden services
 here?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15215#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online