[tor-bugs] #15211 [Tor]: Audit all asserts to ensure they don't have side effects

[Tor Bug Tracker & Wiki]

#15211: Audit all asserts to ensure they don't have side effects
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  minor        |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by nickm):

 * priority:  normal => minor


Comment:

 This is a cool thing to do, but let's remember it isn't critical: The tor
 source doesn't let you define NDEBUG, so we don't need to worry about
 assertions getting eliminated.  This is a style issue, not a safety issue.

 Still, it's worth fixing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15211#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online