[tor-bugs] #14135 [Pluggable transport]: Incorrect SocksListener temporary error check

[Tor Bug Tracker & Wiki]

#14135: Incorrect SocksListener temporary error check
-------------------------------------+--------------------------
     Reporter:  adam-p               |      Owner:  dcf
         Type:  defect               |     Status:  needs_review
     Priority:  minor                |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  goptlib
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+--------------------------

Comment (by dcf):

 Replying to [comment:5 dcf]:
 > What do you think about just not returning errors that happen post-
 Accept during SOCKS negotiation? Something like this:

 BTW I thought about a lot of options but part of my rationale is this
 logic in http.Serve:
 https://github.com/golang/go/blob/77082481d48c8cd8ea93328f9ab962092fe0183f/src/net/http/server.go#L1782
 It does an exponentially increasing delay on Temporary net.Error, and
 quits on any other kind of error. I'm thinking that, if there were an
 analogous situation using SocksListener, we would not want an invalid
 SOCKS handshake to result in this kind of delay handling, which appears to
 be aimed at situations of temporary network overload. So we can just keep
 such errors inside the library and never report them upward.

 I think my original thinking was to report such errors upward so that they
 could be logged, but, eh, whatever. I like that, with this change, the
 Temporary checks match the ones in the standard library.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14135#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online