[tor-bugs] #15482 [Tor]: Don't surprise users with new circuits in the middle of browsing

[Tor Bug Tracker & Wiki]

#15482: Don't surprise users with new circuits in the middle of browsing
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  needs_information
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:
     Priority:  normal   |   Keywords:  tbb-usability, MikePerry201503,
    Component:  Tor      |  tbb-wants, TorBrowserTeam201506R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by rustybird):

 One problem I didn't think through with `IsolateKeepAlive` is that if
 uncredentialed circuits (not associated with any URL bar domain) must not
 be kept alive, then this flag wouldn't really be suitable for TB.

 What do you think about IsolateKeepAliveSOCKSAuth.patch? It's based on
 bug15482.patch, with all the logic kept in place (`IsolateSOCKSAuth` set +
 non-empty SOCKS credentials sent), but also an additional required
 condition (`IsolateKeepAliveSOCKSAuth` set).

 (Other than that I've only unified the `if` and `else if` branches,
 because they were identical in the original bug15482.patch:
 `circ->base_.timestamp_dirty = approx_time();`)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15482#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online