[tor-bugs] #16381 [Tor]: Bad timestamp check when storing an HS descriptor on the client

[Tor Bug Tracker & Wiki]

#16381: Bad timestamp check when storing an HS descriptor on the client
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  SponsorR, tor-hs
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by arma):

 Yes, see #14219 for when this bug went in. git show 9407040c5921

 I think we can't just change >= to >, because then when we get the same
 descriptor, we will not trigger the
 {{{
 +    log_info(LD_REND, "We already have a new enough service descriptor
 for "
                        "service ID %s with the same desc ID and version.",
 }}}
 part.

 It looks like we want to actually see if the descriptor is different.

 Also, if the timestamps really are only at the hour granularity, I think
 we can no longer use them for time ordering of hs descs. Now might be a
 great time to brainstorm totally different approaches, like putting a
 counter in the hs desc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16381#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online