[tor-bugs] #16366 [Tor]: tor hangs for 30 seconds when parsing torrc ending in backslash-newline
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jun 15 14:13:30 UTC 2015
#16366: tor hangs for 30 seconds when parsing torrc ending in backslash-newline
------------------------+--------------------------
Reporter: teor | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Tor: 0.2.???
Component: Tor | Version: Tor: 0.2.6.8
Resolution: | Keywords: lorax
Actual Points: | Parent ID:
Points: |
------------------------+--------------------------
Comment (by teor):
Oh, I completely agree, the attached test program causes the issue to
occur on OS X, but not on Linux. And all it contains is a simple
`getaddrinfo` call that any program could use.
I don't know if it's worth filtering obvious invalid addresses like `\`
and `\n` and `\r` or not. Since we are already parsing and validating
address/port combinations, should we do a very simple validity check with
the name part? (Do we already do some checks? Or do we leave everything
before the colon to `getaddrinfo`?)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16366#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list