[tor-bugs] #16276 [Onionoo]: bug in onionoo's family set detection

[Tor Bug Tracker & Wiki]

#16276: bug in onionoo's family set detection
-----------------------------+-----------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  major        |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by tyseom):

 For simplicity I would prefere
 1) make the implementation do what the documentation says
 or
 3) or: have two explicit fields: declaredfamily and effectivefamily

 In the proposed design I would have to check the diff key (or its absence)
 to tell me whether the family key is actually valid, I'd prefere something
 that is more straight forward. Your design is supperior over (3) when it
 comes to entry size since 3 would store more dublicate data.

 Regarding backwards compatibility:
 I guess there is no one seriously using family as it is documented since
 that would have triggered this discussion earlier. Better have something
 new and clean than to have some backward compatibility for something that
 has been broken.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16276#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online