[tor-bugs] #16269 [meek]: add-on compatibility check occurs repeatedly

[Tor Bug Tracker & Wiki]

#16269: add-on compatibility check occurs repeatedly
------------------------+--------------------
     Reporter:  mcs     |      Owner:  dcf
         Type:  defect  |     Status:  closed
     Priority:  normal  |  Milestone:
    Component:  meek    |    Version:
   Resolution:  fixed   |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------
Changes (by dcf):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:4 mcs]:
 > I understood what you were trying to do; I was just trying to find a
 more robust way to accomplish it.  I did not know about the use of a
 user.js file.  I think that will actually cause the
 network.proxy.socks_remote_dns pref. to be reset to true each time the
 browser starts up.

 Oh, I think you are right. The user.js file should take precedence even if
 we accidentally write socks_remote_dns=false to prefs.js. That's fine,
 it's just another layer in the failsafe.

 > In any case, Kathy and I tested a revised patch that flushes the prefs.
 to disk before the code in components/main.js resets
 network.proxy.socks_remote_dns.  It seems to work fine and solve this
 issue.  I will attach a patch for review.

 Thanks! I applied it and tagged [https://gitweb.torproject.org/pluggable-
 transports/meek.git/tag/?id=0.19 0.19] for you.

 For the record, this is what was added to my profile.meek-http-
 helper/prefs.js after I applied the patch. Before that, it was empty
 except for comments.
 {{{
 user_pref("app.update.enabled", false);
 user_pref("browser.cache.frecency_experiment", 1);
 user_pref("browser.dom.window.dump.enabled", true);
 user_pref("datareporting.healthreport.nextDataSubmissionTime",
 "1433523627528");
 user_pref("datareporting.policy.firstRunTime", "1433437227527");
 user_pref("extensions.blocklist.pingCountVersion", 0);
 user_pref("extensions.enabledAddons", "meek-http-
 helper%40bamsoftware.com:1.0");
 user_pref("extensions.installCache", "[{\"name\":\"app-profile\",\"addons
 \":{\"meek-http-helper at bamsoftware.com\":{\"descriptor\":\"/home/david
 /tor-browser_en-US/Browser/TorBrowser/Data/Browser/profile.meek-http-
 helper/extensions/meek-http-
 helper at bamsoftware.com\",\"mtime\":1433437213000,\"rdfTime\":946713600000}}}]");
 user_pref("extensions.lastAppVersion", "31.7.0");
 user_pref("extensions.lastPlatformVersion", "31.7.0");
 user_pref("extensions.shownSelectionUI", true);
 user_pref("network.proxy.socks_port", 9);
 user_pref("security.ssl.disable_session_identifiers", false);
 user_pref("toolkit.startup.max_resumed_crashes", -1);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16269#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online