[tor-bugs] #16288 [Tor]: The open file limit is not checked before calling tor_accept_socket_nonblocking()

[Tor Bug Tracker & Wiki]

#16288: The open file limit is not checked before calling
tor_accept_socket_nonblocking()
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  026-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by dgoulet):

 * status:  new => needs_review


Comment:

 Initial stab at it. I had to take the approach of keeping the value of max
 file descriptor locally in compat.c else `get_options` wasn't usable
 without a zillion compilation warning when including config.h.

 This has been tested on a relay with a limit of 4096 and it never went
 over 4064 (the OS limit minus `ULIMIT_BUFFER`) for more than an hour of
 testing (takes ~30 minutes to reach the limit).

 Branch: `bug16288_027_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16288#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online