[tor-bugs] #16480 [Tor]: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL

[Tor Bug Tracker & Wiki]

#16480: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL
-----------------------------+-----------------------------------------
     Reporter:  cypherpunks  |      Owner:  nickm
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  TorCoreTeam201508, sponsorS
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------------
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 I think we can remove that entire block from
 connection_write_to_buf_impl_.    So, way #1 it is.  Roger, does anything
 bad happen if we take this out?  I just tried shoving a huge pile of stuff
 onto an output buffer, and everything was fine.

 > Is it still possible to queue so many bytes for control connection, why?

 I think "GETINFO desc/all-recent" can do at least that much.


 See branch `decouple-write` in my public repository?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16480#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online