[tor-bugs] #16651 [Tor]: Tor fails to build on OpenBSD due to libevent config options

[Tor Bug Tracker & Wiki]

#16651: Tor fails to build on OpenBSD due to libevent config options
------------------------+---------------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  bsd 026-backport libevent
Actual Points:          |  Parent ID:
       Points:          |
------------------------+---------------------------------------

Comment (by attila):

 Replying to [comment:1 nickm]:
 > Hm.  The "evthread_use_pthreads" is wrong; Tor only uses libevent from
 the main thread, except when windows bufferevents are in use.  (That could
 be a comment instead.)
 >
 > Has anybody tested this with older (pre-2.0) versions of Libevent, to
 make sure it doesn't break them?
 >

 You are correct, the original patch and several mods that were tossed
 around
 on the tor-bsd mailing list were all subtly wrong.  I have attached a
 patch
 that I think is correct: only compiled in w/libevent2 and --enable-
 bufferevents
 turned on.  Works for me under OpenBSD/i386:
 {{{
 Jul 28 09:55:44.277 [notice] Tor v0.2.7.1-alpha-dev (git-aeeb6376aab186fd)
 (with
  bufferevents) running on OpenBSD with Libevent 2.0.22-stable, OpenSSL
 LibreSSL
 2.2 and Zlib 1.2.3.
 }}}

 Successfully builds circuits and otherwise seems to work.  Most of the
 test suite
 passes but there are four tests that have never passed for me under
 OpenBSD,
 patch notwithstanding... that can be a separate ticket.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16651#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online